Skip to content

Share chart button - #7802

Merged
marthacryan merged 26 commits into
masterfrom
upload-to-cloud-proto
Jun 17, 2026
Merged

Share chart button#7802
marthacryan merged 26 commits into
masterfrom
upload-to-cloud-proto

Conversation

@emilykl

@emilyklemilykl commented May 14, 2026

Copy link
Copy Markdown
Contributor

Modify the existing sendDataToCloud modebar button to share the chart via Plotly Cloud rather than Chart Studio.

The button remains disabled by default. Note that the Plotly Cloud endpoint for receiving charts is not yet functional, so the full sharing feature is not yet ready, but the UI can be previewed by setting showSendToCloud: true in the plot config.

Since the Chart Studio website is no longer online, the existing "share to Cloud" logic was not functional, so this should not be a breaking change.

Codepen: https://codepen.io/marthacryan/pen/dPOmREK

@emilykl
emilyklforce-pushed the upload-to-cloud-proto branch from a487ce9 to 100da7bCompareMay 14, 2026 17:16
@emilyklemilykl changed the title draftShare chart buttonMay 20, 2026
@marthacryan
marthacryan marked this pull request as ready for review May 28, 2026 20:38
@marthacryan
marthacryan marked this pull request as draft May 28, 2026 20:40
@marthacryanmarthacryan self-assigned this May 28, 2026
Comment threadsrc/components/modebar/cloud_confirm.js Outdated
Comment threadsrc/plot_api/plot_config.js Outdated
Comment threadsrc/plots/plots.js Outdated
Comment threadsrc/plots/plots.js Outdated
@marthacryan
marthacryan marked this pull request as ready for review June 11, 2026 02:33
Comment threadsrc/components/modebar/cloud_confirm.js Outdated
Comment threadsrc/plots/plots.js Outdated
Comment on lines 204 to 205
plots.sendDataToCloud = function(gd) {
var baseUrl = (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL;

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to pass in baseUrl / serverUrl as an argument, so that we don't have to duplicate this (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerURL logic

Comment threadsrc/plots/plots.js
Comment threadsrc/components/modebar/buttons.js Outdated
Comment threadtest/plot-schema.json Outdated
@emilykl
emilyklforce-pushed the upload-to-cloud-proto branch from 396b681 to c1b7122CompareJune 15, 2026 20:21
Comment threadsrc/components/modebar/cloud_confirm.js Outdated
Comment threadsrc/components/modebar/buttons.js
@marthacryan
marthacryan merged commit 81f20cc into masterJun 17, 2026
29 of 31 checks passed
@marthacryan
marthacryan deleted the upload-to-cloud-proto branch June 17, 2026 17:29
Comment threadsrc/plots/plots.js
plots.layoutAttributes = require('./layout_attributes');

var commandModule = require('./command');
const { server } = require('karma');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import of a dev-dependency is not used in the source code.

@archmoj

Copy link
Copy Markdown
Contributor

This PR is missing a draft log. cc: @emilykl

camdecoster added a commit that referenced this pull request Jun 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@emilykl@archmoj@camdecoster@marthacryan