Animate API by rreusser · Pull Request #802 · plotly/plotly.js

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

rreusser · 2016-08-01T20:10:25Z

I made a mess of #717 by letting it go too long and performing a bad merge/rebase or two. This PR handles animation and attempts to get all tests passing.

Checklist:

etpinard · 2016-08-22T14:43:26Z

@rreusser what's the current status of this PR?

rreusser · 2016-08-22T18:20:53Z

Currently trying to solve race condition with the autolayout feature. I was cheating a bit and timing transitions independently of d3's execution of the transitions, but that tends to result in problematic race conditions in which every now and then a d3 update comes through after the transitions has been redrawn. I feel like I'm attempting to group my transitions correctly, but the just don't group.

@monfera, do you have experience with grouping d3 v3 transitions? I put large chunks that create more transitions inside a .transition().each(...), but the properties don't seem to get inherited.

Also, @etpinard, are you aware of a straightforward way to temporarily disable autorange while performing a redraw? With the cleanup, it now autoranges when redraw is called at the end of transitions, which is rarely desirable.

rreusser · 2016-08-23T18:43:27Z

To do:

disable dragbox while axis transition is in progress

etpinard · 2016-08-23T19:12:24Z

 }

- if(xObj.visible && isNumeric(coords.y) &&
+ if(xObj.visible && isNumeric(coords.x) &&


Oh wow, good catch. 😬

etpinard · 2016-09-06T19:11:51Z

@rreusser a very well-deserved 💃

cc @chriddyp @jackparmer @cldougl

jackparmer · 2016-09-06T20:22:06Z

An epic piece of work @rreusser !

- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!

etpinard added feature something new status: in progress labels Aug 2, 2016

rreusser force-pushed the animate-api-take-4 branch 4 times, most recently from 7bf81a0 to 06d1e46Compare August 5, 2016 16:57

etpinard added this to the v1.17.0 milestone Aug 5, 2016

rreusser force-pushed the animate-api-take-4 branch 3 times, most recently from d14cc15 to fbfbf53Compare August 11, 2016 19:52

rreusser mentioned this pull request Aug 12, 2016
lib function to interleave trace updates into a restyle #847
Closed

rreusser force-pushed the animate-api-take-4 branch 3 times, most recently from 0f92220 to 7447887Compare August 12, 2016 17:16

rreusser force-pushed the animate-api-take-4 branch from 7447887 to 0946987Compare August 23, 2016 16:09

etpinard reviewed Aug 23, 2016
View reviewed changes

rreusser added 14 commits September 6, 2016 12:58

Refactor animationOpts API
0221c79

Apply non-range props from layout to transition
f3a292d

Use Lib.isPlainObject instead of typeof
f709572

Stop testing the things that don't pass the tests 😑
68b9a0c

Switch to window.[request|cancel]AnimationFrame for consistency
29c14d7

Remove .transition from core
84c93fe

Add immediate interrupt
75ec8a5

Fix one of the animate tests
c8e46f2

Tweak tests
1d43355

Fix race condition in .animate
1fe652d

Limit transition duration to <= frame duration
2bc29b8

jsDoc for animate, addFrames, and deleteFrames
0f23eef

Verify gd is a plot div for animate, addFrames, deleteFrames
c85c3a2

Throw animate API errors whne gd is not a plot
4e88184

rreusser force-pushed the animate-api-take-4 branch from f43ac01 to 4e88184Compare September 6, 2016 18:58

rreusser merged commit d736910 into masterSep 6, 2016

rreusser mentioned this pull request Sep 6, 2016
Animation when the populating the chart with new data set. #142
Closed

etpinard deleted the animate-api-take-4 branch September 6, 2016 22:09

etpinard mentioned this pull request Sep 6, 2016
Introducing Plotly.update#875
Merged

This was referenced Sep 8, 2016
Hotfix: clean up visible false scatter trace #920
Merged
Invisible traces in 1.17.0+ when using Plotly.redraw #942
Closed

This was referenced Sep 15, 2016
Clean data & layout on Plotly.redraw #947
Merged
data text position is not refreshed on zoom or pan #952
Closed
Multiple scatter plot fixes #956
Merged

etpinard mentioned this pull request Nov 24, 2016
Remove erroneous traces in multi-subplot layout containing fill-to scatter traces #1198
Merged

etpinard mentioned this pull request Jun 7, 2017
Identification of selected points with a key #1765
Closed