Improve tasks CLI by etpinard · Pull Request #821 · plotly/plotly.js

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard · 2016-08-04T20:49:02Z

resolves#794

In brief

this PR:

rewrote all the remaining shell script found in tasks/ in node which (1) will allow to Windows users to run them hassle-free (2) allow us to DRY up significant amounts of tasks code.
refactored the pretest lifecycle task. It now contains everything needed to prep up the CircleCI box before testing including booting up the imagetest docker container (which cleans up our circle.yml significantly)
hard-coded the mapbox access token used for testing into tasks/util/constants.js. No more export <mapbox-access-token> needed to start dev'ing!
the other commits DRYed up the existing tasks/ and devtools/ code.

Ideas for future development

Drop docker-compose for booting the imagetest container locally. That would mean one less dependency for devs 🎉 . Use npm run pretest instead (and maybe add an npm run postest task to shut down the container while at it).
Factor out all bundling code into a separate module (see Should we expose a high-level bundler module / CLI ? #768)

- to make it consistent with `npm run watch`

- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

- format bundle does not make sense in a non-watchify context

- use in watchified bundle module

- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard · 2016-08-04T20:50:02Z

- - sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
- - sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
+ - npm run test-image
+ - npm run test-export


the local vs CI differences are now handled at the task-runner script level.

mdtusz · 2016-08-05T14:26:27Z

-updateVersion(constants.pathToPlotlyGeoAssetsSrc);
+// copy topojson files from sane-topojson to dist/
+function copyTopojsonFiles() {
+ fs.copy(constants.pathToTopojsonSrc, constants.pathToTopojsonDist,


🐄 separate lines for each arg?

mdtusz · 2016-08-05T14:32:56Z

Great PR!

After those little cows and things, 💃 !

etpinard · 2016-08-05T19:23:02Z

 containerCommands.setup = [
 containerCommands.cpIndex,
 containerCommands.restart,
+ 'sleep 1',


Looks like the npm run pretest is a little more flaky than the previous list of shell commands on CIrcleCi.
Not sure what's up.
I've added sleep delays:
between the nw restart and the ping as well as as
between the docker run and setup commands.
Hopefully that will fix it. But we might have to look into this further.

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

etpinard added 24 commits August 4, 2016 16:10

tasks: rewrite all test container sh scripts in node
45a548c

tasks: use node script to run image/export on circleci
1291888

fixup: docker pull testbed
262e90d

tasks: sub fs.existsSync for fs.statSync
0fd57ba

dry: look up container url in constants.js
3712e17

tasks: rename watch_plotly.js -> watch.js
5758129
- to make it consistent with `npm run watch`

tasks: move test syntax script to tasks/
bac6685

tasks: add common task util module
f564a85

tasks: use common utils
04096de

lint: group preprocess in sub-routines
7040e49

lint: group stats in sub-routines
5e04f37

tasks: hard code mapbox access token in constants.js
aca8fa0
- no need to hide mapbox access tokens (there are public) - remove `export MAPBOX_ACCESS_TOKEN` step in contributing guide

tasks: merge CI vs local run cmd logic in container command module
30c1b86

tasks: add docker run command
640bdb4

tasks: refactor pretest
584e644
- group sub-tasks in subroutines - DRY up using common module - add image test container setup sub-task such that `npm run pretest` on CircleCI runs the docker container and sets it up once and for all

tasks: use common module in container tasks
0001833

rm sub-tasks on circle.yml that are now part of pretest
1c91068

fixup: make container commands work on CI
a793734

tasks: a few stats.js fixups
d5cb921

tasks: merge format bundle make watchified bundle script
f662025
- format bundle does not make sense in a non-watchify context

DRY: use watchified bundle util in test dashboard server
294cad0

rm useless eslintrc
c479fe6

tasks: add formatTime common util
8a4f5ee
- use in watchified bundle module

tasks: add get time last modified util
e5ee342
- use in image test container tasks to display to the last build/plotly.js bundle time.

etpinard added type: maintenance labels Aug 4, 2016

etpinard reviewed Aug 4, 2016
View reviewed changes

mdtusz reviewed Aug 5, 2016
View reviewed changes

etpinard added 2 commits August 5, 2016 14:10

lint & comment
7c0562f

tasks: add sleep (try to make pretest make consistent)
cfda7d3

etpinard reviewed Aug 5, 2016
View reviewed changes

etpinard merged commit 2a20e93 into masterAug 5, 2016

etpinard deleted the better-tasks-cli branch August 5, 2016 19:28

This was referenced Aug 12, 2016
Bump server repsonse retry limit to 20 #849
Merged
Don't use child_process.exec to setup docker container on CircleCI #853
Merged

Uh oh!

Uh oh!

Conversation

etpinard commented Aug 4, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In brief

Ideas for future development

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdtusz commented Aug 5, 2016

Uh oh!

etpinardAug 5, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Aug 4, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In brief

Ideas for future development

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdtusz commented Aug 5, 2016

Uh oh!

etpinardAug 5, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Aug 4, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In brief

Ideas for future development

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdtusz commented Aug 5, 2016

Uh oh!

etpinardAug 5, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

etpinard commented Aug 4, 2016•
edited
Loading

etpinardAug 5, 2016•
edited
Loading

etpinard commented Aug 4, 2016•
edited
Loading

etpinardAug 5, 2016•
edited
Loading

etpinard commented Aug 4, 2016•
edited
Loading

etpinardAug 5, 2016•
edited
Loading

etpinard commented Aug 4, 2016•
edited
Loading

etpinardAug 5, 2016•
edited
Loading

etpinard commented Aug 4, 2016•
edited
Loading