Use plotly.min.js in both JS bundles by nicolaskruchten · Pull Request #2103 · plotly/plotly.py

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten · 2020-01-20T18:10:41Z

Closes#1873 the opposite way from #1891 so as not to bloat the classic nbextension size. If we wanted to do things the #1891 way we would need to add minification in plotlywidget/webpack.config.js so that the nbextension stays small. I'm indifferent but this way seemed easy :)

This PR also inlines the randstr function the same way, and removes the prepublish: webpack line that fails if webpack isn't globally installed, as well as the nonfunctional build target that calls tsc, replacing them with a build: webpack target that gets called explicitly in the CI step.

The bundle size savings of this change are substantial on a percentage basis: both bundles together are now roughly the size of either bundle, as expected, instead of twice. Also PS I resurrected the jupyterlab-chart-editor and it uses the min bundle right now so the savings should be compounded if all three are installed.

(closes#1891 if merged!)

nicolaskruchten · 2020-01-21T20:30:02Z

- "build:src": "rimraf dist && tsc",
+ "build": "webpack",
 "clean": "rimraf dist/ && rimraf ../../python/plotly/plotlywidget/static'",
- "prepublish": "webpack",


this prepublish thing is deprecated. It seems like NPM tries to run it when doing npm install and fails unless you have webpack installed globally for some reason.

nicolaskruchten · 2020-01-21T20:30:17Z

 ],
 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",


this isn't a TypeScript module so this doesn't seem to do much

nicolaskruchten · 2020-01-21T20:31:05Z

 "scripts": {
- "build": "npm run build:src",
- "build:src": "rimraf dist && tsc",
+ "build": "webpack",


The build for this package is, in fact webpack, and running npm run build does use the installed webpack in node_modules. So now we have to run npm install && npm run build and there are no deprecation warnings :)

jonmmease · 2020-01-22T10:42:01Z

 },
 "dependencies": {
- "plotly.js": "^1.51.2",
+ "plotly.js": "^1.52.1",


Did you intend to downgrade plotly.js here?

That’s an upgrade actually ;)

jonmmease · 2020-01-22T10:43:12Z

One question above, but this looks good to me, assuming you've smoke tested the extensions in JupyterLab.

Thanks @nicolaskruchten!

nicolaskruchten · 2020-01-22T12:30:58Z

I’ve smoke tested by uninstalling, building and reinstalling both extensions... is that about right?

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

nicolaskruchten added 2 commits January 20, 2020 13:08

both bundles use min
1494a25

clean up package.json build steps
304745e

nicolaskruchten mentioned this pull request Jan 20, 2020
Effect on JupyterLab bundle size #1873
Closed

explicitly run webpack in plotlywidget
16b5f0b

nicolaskruchten requested a review from jonmmease January 20, 2020 18:31

nicolaskruchten added this to the v4.5.0 milestone Jan 20, 2020

explicitly run webpack in plotlywidget
209daab

nicolaskruchten commented Jan 21, 2020
View reviewed changes

jonmmease reviewed Jan 22, 2020
View reviewed changes

nicolaskruchten merged commit e031443 into masterJan 22, 2020

nicolaskruchten deleted the reduce_jlab_bundle_size branch June 19, 2020 16:13

Uh oh!

Uh oh!

Conversation

nicolaskruchten commented Jan 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonmmease commented Jan 22, 2020

Uh oh!

nicolaskruchten commented Jan 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

nicolaskruchten commented Jan 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonmmease commented Jan 22, 2020

Uh oh!

nicolaskruchten commented Jan 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

nicolaskruchten commented Jan 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonmmease commented Jan 22, 2020

Uh oh!

nicolaskruchten commented Jan 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

nicolaskruchten commented Jan 20, 2020•
edited
Loading

nicolaskruchten commented Jan 22, 2020•
edited
Loading

nicolaskruchten commented Jan 20, 2020•
edited
Loading

nicolaskruchten commented Jan 22, 2020•
edited
Loading

nicolaskruchten commented Jan 20, 2020•
edited
Loading

nicolaskruchten commented Jan 22, 2020•
edited
Loading

nicolaskruchten commented Jan 20, 2020•
edited
Loading

nicolaskruchten commented Jan 22, 2020•
edited
Loading