Skip to content

Fix TypeError: When using orjson and serializing pandas.NA - #5040

Merged
marthacryan merged 2 commits into
plotly:mainfrom
DavidKatz-il:fix-5039
Feb 18, 2025
Merged

Fix TypeError: When using orjson and serializing pandas.NA#5040
marthacryan merged 2 commits into
plotly:mainfrom
DavidKatz-il:fix-5039

Conversation

@DavidKatz-il

Copy link
Copy Markdown
Contributor

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

closes#5039

@gvwilsongvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Feb 18, 2025
@gvwilson

Copy link
Copy Markdown
Contributor

Thanks for this @DavidKatz-il - I'll try to have someone review ASAP.

@marthacryanmarthacryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marthacryan
marthacryan merged commit a6ee27c into plotly:mainFeb 18, 2025
@DavidKatz-il
DavidKatz-il deleted the fix-5039 branch February 18, 2025 21:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

communitycommunity contributionfixfixes something brokenP1needed for current cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: When using orjson and serializing pandas.NA

3 participants

@DavidKatz-il@gvwilson@marthacryan