Skip to content

Use native legends when converting from matplotlib - #5312

Merged
emilykl merged 3 commits into
plotly:mainfrom
robertoffmoura:rm/use-native-legend
Oct 1, 2025
Merged

Use native legends when converting from matplotlib#5312
emilykl merged 3 commits into
plotly:mainfrom
robertoffmoura:rm/use-native-legend

Conversation

@robertoffmoura

Copy link
Copy Markdown
Contributor

Use native legends (showlegend = true) instead of recreating them using shapes and annotations.

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@gvwilson
gvwilson requested a review from emilyklAugust 11, 2025 17:08
@gvwilsongvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Aug 11, 2025
@emilykl

Copy link
Copy Markdown
Contributor

Thank you for the contribution @robertoffmoura ! This is great.

Could you run ruff format on the modified files and commit the changes, so that the code_formatting CI job will pass?

(There's a failure in build as well but that one looks unrelated to this PR.)

@robertoffmoura

Copy link
Copy Markdown
ContributorAuthor

Thanks, Emily! Done, just pushed a new commit after running ruff format.

@emilyklemilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again @robertoffmoura 🚀

@emilykl
emilykl merged commit aa4c088 into plotly:mainOct 1, 2025
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

communitycommunity contributionfixfixes something brokenP1needed for current cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@robertoffmoura@emilykl@gvwilson