Skip to content

Fix broken import in mplexporter tests - #5322

Merged
emilykl merged 3 commits into
plotly:mainfrom
mgorny:plt-import
Oct 1, 2025
Merged

Fix broken import in mplexporter tests#5322
emilykl merged 3 commits into
plotly:mainfrom
mgorny:plt-import

Conversation

@mgorny

Copy link
Copy Markdown
Contributor

Fixes#5253

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

Fixesplotly#5253
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gvwilson
gvwilson self-requested a review August 13, 2025 18:47
@gvwilsongvwilson self-assigned this Aug 13, 2025
@gvwilsongvwilson added P1 needed for current cycle community community contribution fix fixes something broken testing automated tests labels Aug 13, 2025

@emilyklemilykl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this, but it's worth mentioning that the mplexporter tests aren't currently running in the CI (which is how this was missed in the first place).

There are also two failing mplexporter tests currently:

FAILED plotly/matplotlylib/mplexporter/tests/test_basic.py::test_legend_dots - AssertionError: assert '3' == '2'
FAILED plotly/matplotlylib/mplexporter/tests/test_utils.py::test_linestyle - AssertionError: 

I've opened #5360 to track.

@emilykl
emilykl merged commit fbbc9d6 into plotly:mainOct 1, 2025
8 checks passed
@emilyklemilykl mentioned this pull request Oct 1, 2025
@mgorny
mgorny deleted the plt-import branch October 2, 2025 03:20
@mgorny

Copy link
Copy Markdown
ContributorAuthor

Thank you!

@emilykl

Copy link
Copy Markdown
Contributor

Thank you for the fix @mgorny !! 🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

communitycommunity contributionfixfixes something brokenP1needed for current cycletestingautomated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken imports in matplotlib tests in 6.2.0

3 participants

@mgorny@emilykl@gvwilson