Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 2.8k
create_hexbin_mapbox uses *_map chart types instead of *_mapbox#5358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
7c589f8b9a271d565a92ccd2d4adbd178f65b38811dd3bd89ebb62094d8fbc49773b5fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -29,12 +29,18 @@ | ||||||||||||||||
| if optional_imports.get_module("pandas") is not None: | ||||||||||||||||
| from plotly.figure_factory._county_choropleth import create_choropleth | ||||||||||||||||
| from plotly.figure_factory._hexbin_mapbox import create_hexbin_mapbox | ||||||||||||||||
| from plotly.figure_factory._hexbin_map import ( | ||||||||||||||||
| create_hexbin_map, | ||||||||||||||||
| create_hexbin_mapbox, | ||||||||||||||||
| ) | ||||||||||||||||
| else: | ||||||||||||||||
| def create_choropleth(*args, **kwargs): | ||||||||||||||||
| raise ImportError("Please install pandas to use `create_choropleth`") | ||||||||||||||||
| def create_hexbin_map(*args, **kwargs): | ||||||||||||||||
| raise ImportError("Please install pandas to use `create_hexbin_map`") | ||||||||||||||||
Comment on lines
+41
to
+42
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ||||||||||||||||
| def create_hexbin_mapbox(*args, **kwargs): | ||||||||||||||||
| raise ImportError("Please install pandas to use `create_hexbin_mapbox`") | ||||||||||||||||
| @@ -57,6 +63,7 @@ def create_ternary_contour(*args, **kwargs): | ||||||||||||||||
| "create_distplot", | ||||||||||||||||
| "create_facet_grid", | ||||||||||||||||
| "create_gantt", | ||||||||||||||||
| "create_hexbin_map", | ||||||||||||||||
emilykl marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||||||||||||||||
| "create_hexbin_mapbox", | ||||||||||||||||
| "create_ohlc", | ||||||||||||||||
| "create_quiver", | ||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the
px.set_mapbox_access_token(open(".mapbox_token").read())lines in these examples and the information about mapbox tokens in the introduction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9773b5