Uh oh!
There was an error while loading. Please reload this page.
Ipyplotly test fixes - #974
Conversation
New codegen logic in codegen/ New datatype classes generated into plotly/datatypes/ (These are gitignored) New validator classes generated into plotly/validators/ (These are gitignored) Code generation in update_graph_objs.py modified to map Figure, Layout, and Trace types to new plotly/datatypes/ classes. All other classes mapped to raw dicts/lists.
It's now possible to execute a fair amount of legacy graph construction and plotting code
TODO: add support for datetime arrays in validation and in widget serialization
Added js/ directory containing front-end widget library Added graph_objs.FigureWidget class that maps to datatypes.FigureWidget
These are mostly just for discussion during the WIP integration process.
Kully
commented
Mar 15, 2018
@chriddyp @jmmease |
| @@ -0,0 +1,27 @@ | |||
| *.egg-info/ | |||
There was a problem hiding this comment.
@Kully - It looks like you committed a lot of extra stuff, like this ipyplotly folder. Was that intentional? If not, could you rebase and open up a new PR?
There was a problem hiding this comment.
I highly recommend using a git client like GitHub desktop https://desktop.github.com/ to make your commits - it makes a lot easier to view what you will commit before committing it, as well as organizing your commits to only include certain files and line numbers
There was a problem hiding this comment.
It was intentional. ipyplotlycan't be located without the folder in ploty.py
chriddyp
commented
Mar 15, 2018
Also, could you make the PR against the original PR instead of |
Kully
commented
Mar 15, 2018
Closing in favor of #975 |
Attempting to fix minor test failures in #942