Uh oh!
There was an error while loading. Please reload this page.
Fillable candlestick. - #226
Conversation
Codecov Report
@@ Coverage Diff @@## master #226 +/- ##
==========================================
- Coverage 68.83% 68.65% -0.19%
==========================================
Files 56 56 Lines 4313 4300 -13 ==========================================
- Hits 2969 2952 -17 - Misses 1344 1348 +4
Continue to review full report at Codecov.
|
inconspicuous99
commented
Jun 20, 2022
what happened to this one? |
facorread
commented
Jun 20, 2022
@inconspicuous99 This PR failed both checks; the project has implemented new checks since. Would you like to propose an updated PR and some tests? The project would appreciate it. |
38
commented
Jul 4, 2022
Seems we already have merged a PR that fix the bug that candlestick element discard the filled field from the style. See b41b5a7 Plus this change just make the Candlestick::new doesn't compatible with previous version, thus it's a breaking change. So I am prefer the fix I linked above. Thanks for your contribution and please don't mind I close the PR. |
This PR allows filling the inside area of candlesticks: