Skip to content

Fix rect bottom right edges - #378

Merged
38 merged 5 commits into
plotters-rs:masterfrom
shinmili:fix-rect-bottom-right-edges
Jun 27, 2022
Merged

Fix rect bottom right edges#378
38 merged 5 commits into
plotters-rs:masterfrom
shinmili:fix-rect-bottom-right-edges

Conversation

@shinmili

Copy link
Copy Markdown
Contributor

Close#368.

@38

38 commented Jun 25, 2022

Copy link
Copy Markdown
Member

Thanks for the PR, I think this make a lot of sense to me!

But again, IMO it's not a really a solution but a mitigation - And I am looking forward we can reach the point that we define a sound and uniformed backend abstraction at some point.

The change itself looks good to me!

I am wondering if @facorread and @AaronErhardt have any comment on the PR.

@38
38 requested review from AaronErhardt and facorreadJune 25, 2022 19:50
@facorread

Copy link
Copy Markdown
Member

I agree! I know it can be frustrating that a project chooses a long-term abstraction over a short-term solution, but the discussion here highlights the need for it. Let us try to build it!

@AaronErhardtAaronErhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@facorreadfacorread left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nitpick of course, can you please address the warning below? It looks like removing one line should do it. Thanks!

@shinmili

shinmili commented Jun 26, 2022

Copy link
Copy Markdown
ContributorAuthor

@facorread Thanks for pointing out. The warning indicates the test below is actually not run on GitHub Actions, so I edited the test command line to make it run, instead of removing the line with warning.

@38
38 requested a review from facorreadJune 26, 2022 17:22
@38
38 merged commit 35b2060 into plotters-rs:masterJun 27, 2022
@shinmili
shinmili deleted the fix-rect-bottom-right-edges branch June 28, 2022 16:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] DrawingArea::fill doesn't fill the right and bottom edge in some backends

4 participants

@shinmili@38@facorread@AaronErhardt