Uh oh!
There was an error while loading. Please reload this page.
Fix rect bottom right edges - #378
Conversation
38
commented
Jun 25, 2022
Thanks for the PR, I think this make a lot of sense to me! But again, IMO it's not a really a solution but a mitigation - And I am looking forward we can reach the point that we define a sound and uniformed backend abstraction at some point. The change itself looks good to me! I am wondering if @facorread and @AaronErhardt have any comment on the PR. |
facorread
commented
Jun 25, 2022
I agree! I know it can be frustrating that a project chooses a long-term abstraction over a short-term solution, but the discussion here highlights the need for it. Let us try to build it! |
facorread
left a comment
There was a problem hiding this comment.
This is nitpick of course, can you please address the warning below? It looks like removing one line should do it. Thanks!
@facorread Thanks for pointing out. The warning indicates the test below is actually not run on GitHub Actions, so I edited the test command line to make it run, instead of removing the line with warning. |
Close#368.