Skip to content

Added option to provide round id while settling the market - #129

Open
udkreddySomish wants to merge 9 commits into
masterfrom
fix-marketSettlement
Open

Added option to provide round id while settling the market#129
udkreddySomish wants to merge 9 commits into
masterfrom
fix-marketSettlement

Conversation

@udkreddySomish

@udkreddySomishudkreddySomish commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

Settle market by passing the round id for fetching the price from the feed address.
Allow passing round id in createMarket function, which is used in settling the previous market.
Updated MarketUtility to check the passed roundid and return correct asnwer and round id as per the timestamp

maxsam4
maxsam4 requested changes Jan 6, 2021
View reviewed changes
Comment threadcontracts/MarketUtilityV2_1.sol Outdated
Comment threadcontracts/MarketUtilityV2_1.sol
Comment threadcontracts/MarketUtilityV2_1.sol
Comment threadcontracts/AllMarketsV2.sol
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxsam4maxsam4maxsam4 approved these changes
@nitika-goelnitika-goelAwaiting requested review from nitika-goel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@udkreddySomish@maxsam4@smrMadhan