Skip to content
This repository was archived by the owner on Jul 6, 2021. It is now read-only.

Feature/external tools - #56

Merged
btry merged 6 commits into
developfrom
feature/external-tools
Feb 20, 2017
Merged

Feature/external tools#56
btry merged 6 commits into
developfrom
feature/external-tools

Conversation

@trasher

Copy link
Copy Markdown
Contributor

No description provided.

@btrybtry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useless to add composer.lock to tracked files.

Also, there are 2 indentation problems.

Comment threadinc/profile.class.php Outdated
break;

case '1.4':
case '1.4.1':

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pbpcbf was probably a bit lost here.

Comment threadinc/simcard.class.php Outdated

$DB->query($sql) or die($DB->error());
}
break;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation here too

@trasher

Copy link
Copy Markdown
ContributorAuthor

I think it is useless to add composer.lock to tracked files.

Not really; this ensures the versions used are "fixed" on composer install

@btrybtry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@btry
btry merged commit d1358d5 into developFeb 20, 2017
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@trasher@btry