Skip to content

Sense calls Sed load function which enables battery configuration parameters#258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirixmjm merged 10 commits into from
Jun 10, 2025
Merged

Sense calls Sed load function which enables battery configuration parameters #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a9a6b3
call super().load to enable configuratin as NodeFeature.BATTERY
dirixmjm Jun 10, 2025
513ecc9
Remove double is_battery_powered line
bouwew Jun 10, 2025
399738e
Implement SENSE_FEATURES constant
bouwew Jun 10, 2025
023bce3
Make use of super().load() boolean-return
bouwew Jun 10, 2025
72e3203
Let's keep/add debug messages for troubleshooting
bouwew Jun 10, 2025
1352156
update changelog and bump to 0.44.1
dirixmjm Jun 10, 2025
b0c3674
fix indent issue
dirixmjm Jun 10, 2025
cbd1087
Clarify scope of change
bouwew Jun 10, 2025
d3a7ac2
Fix typo in version nr
bouwew Jun 10, 2025
21a3b10
Remove left-over %s
bouwew Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
# Changelog

## v0.44.1

- PR [#258](https://github.com/plugwise/python-plugwise-usb/pull/258)
- Sense: make sure NodeFeature.BATTERY is called and configuration parameters are propagated properly

## v0.44.0

- PR [#256](https://github.com/plugwise/python-plugwise-usb/pull/256) Implement PlugWise Sense product
Expand Down
20 changes: 8 additions & 12 deletions plugwise_usb/nodes/sense.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,21 +51,17 @@ async def load(self) -> bool:
if self._loaded:
return True

self._node_info.is_battery_powered = True
if self._cache_enabled:
_LOGGER.debug("Loading Sense node %s from cache", self._node_info.mac)
await self._load_from_cache()
else:
self._load_defaults()
self._loaded = True
self._setup_protocol(
SENSE_FIRMWARE_SUPPORT,
(NodeFeature.INFO, NodeFeature.SENSE),
)
_LOGGER.debug("Loading Sense node %s", self._node_info.mac)
if not await super().load():
_LOGGER.debug("Load Sense base node failed")
return False

self._setup_protocol(SENSE_FIRMWARE_SUPPORT, SENSE_FEATURES)
if await self.initialize():
await self._loaded_callback(NodeEvent.LOADED, self.mac)
return True
_LOGGER.debug("Loading of Sense node %s failed", self._node_info.mac)

_LOGGER.debug("Load Sense node %s failed", self._node_info.mac)
return False

@raise_not_loaded
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "plugwise_usb"
version = "0.44.0"
version = "0.44.1"
license = "MIT"
keywords = ["home", "automation", "plugwise", "module", "usb"]
classifiers = [
Expand Down