Skip to content

Fully match version - #288

Merged
CoMPaTech merged 1 commit into
mainfrom
tp
Jul 17, 2025
Merged

Fully match version#288
CoMPaTech merged 1 commit into
mainfrom
tp

Conversation

@CoMPaTech

@CoMPaTechCoMPaTech commented Jul 16, 2025

Copy link
Copy Markdown
Member

Fix release matching (also see plugwise/python-plugwise#772)

Summary by CodeRabbit

  • Chores
    • Improved workflow efficiency by streamlining the process for checking existing package versions during publishing and verification steps. This change reduces resource usage and simplifies the version check logic.

@CoMPaTech
CoMPaTech requested a review from a team as a code ownerJuly 16, 2025 14:51
@CoMPaTechCoMPaTech added the bug Something isn't working label Jul 16, 2025
@coderabbitai

coderabbitaiBot commented Jul 16, 2025

Copy link
Copy Markdown

Walkthrough

The changes update two GitHub Actions workflow files by removing the use of an intermediate variable for storing package versions fetched from PyPI and TestPyPI. Instead, the version existence check is now performed directly in the conditional statement using a streamlined command pipeline.

Changes

File(s)Change Summary
.github/workflows/merge.yml, .github/workflows/verify.ymlRefactored version existence checks to eliminate intermediate variable; now use direct streaming with jq and grep in conditionals.

Sequence Diagram(s)

sequenceDiagram
participant Workflow
participant PyPI/TestPyPI
participant jq/grep
Workflow->>PyPI/TestPyPI: Fetch package versions (JSON)
PyPI/TestPyPI-->>Workflow: Return JSON data
Workflow->>jq/grep: Stream version keys and check for target version
jq/grep-->>Workflow: Return match result
Workflow->>Workflow: Decide to skip or publish based on result
Loading

Possibly related PRs

Suggested reviewers

  • dirixmjm

Poem

In the garden of workflows, a bunny hops light,
No more storing versions, just streaming them right!
With jq and grep, the check’s now a breeze—
Direct and efficient, it’s done with such ease.
Hooray for the code, so simple and neat,
This rabbit approves—now onward, repeat! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c01e9ec and bd6f2c4.

📒 Files selected for processing (2)
  • .github/workflows/merge.yml (1 hunks)
  • .github/workflows/verify.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Process test coverage
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecovBot commented Jul 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (c01e9ec) to head (bd6f2c4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #288 +/- ##
=======================================
Coverage 80.90% 80.90% =======================================
Files 36 36 Lines 7584 7584 =======================================
Hits 6136 6136 Misses 1448 1448 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouwewbouwew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working in python-plugwise github

@CoMPaTech
CoMPaTech merged commit 4851a66 into mainJul 17, 2025
17 checks passed
@CoMPaTech
CoMPaTech deleted the tp branch July 17, 2025 08:33
bouwew added a commit that referenced this pull request Jul 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CoMPaTech@bouwew