Skip to content

Improve fixtures and include newlines - #312

Merged
CoMPaTech merged 9 commits into
mainfrom
fixture_imp
May 6, 2023
Merged

Improve fixtures and include newlines#312
CoMPaTech merged 9 commits into
mainfrom
fixture_imp

Conversation

@CoMPaTech

@CoMPaTechCoMPaTech commented May 5, 2023

Copy link
Copy Markdown
Member

Improve fixtures as discussed (and less hassle between python module and custom_component/Core-integration)

@CoMPaTech
CoMPaTech requested a review from bouwew as a code ownerMay 5, 2023 08:59
@CoMPaTechCoMPaTech added enhancement New feature or request quality labels May 5, 2023
@codecov

codecovBot commented May 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #312 (d1938b6) into main (c83c4e2) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## main #312 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 6 6 Lines 2629 2629 =========================================
Hits 2629 2629 
Impacted FilesCoverage Δ
tests/test_smile.py100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CoMPaTechCoMPaTech self-assigned this May 5, 2023
@CoMPaTech

Copy link
Copy Markdown
MemberAuthor

Re-work autogenerating (now exposed) fixtures for action in #313

@CoMPaTech
CoMPaTech marked this pull request as draft May 5, 2023 17:40
@CoMPaTechCoMPaTech linked an issue May 5, 2023 that may be closed by this pull request
@CoMPaTech
CoMPaTech marked this pull request as ready for review May 5, 2023 18:55

@bouwewbouwew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoMPaTech
CoMPaTech merged commit 8deac4b into mainMay 6, 2023
@CoMPaTech
CoMPaTech deleted the fixture_imp branch May 6, 2023 17:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or requestquality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO]: Create Fixture generation/prettier GitHub on-merge action

2 participants

@CoMPaTech@bouwew