Skip to content

Fix coverage from recent v3/v4 changes#615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouwew merged 3 commits into from
Sep 9, 2024
Merged

Fix coverage from recent v3/v4 changes #615

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e10f676
Debug test
CoMPaTech Sep 9, 2024
856c5db
Fix for upload-artifact #602
CoMPaTech Sep 9, 2024
6683e03
Fix paste failure
CoMPaTech Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/verify.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,8 +51,6 @@ jobs:
pip install uv
uv pip install -U pip setuptools wheel
uv pip install -r requirements_test.txt -r requirements_commit.txt
# TODO: Remove after update of aiohttp beyond 3.10.0
uv pip show aiohttp | grep -q "Version: 3.10.0" && (grep -q "core.locations" venv/lib/python*/site-packages/aiohttp/web_urldispatcher.py && echo " *** aiohttp already patched" || ( echo "Patching aiohttp 3.10.0 for tests"; patch -tRup0 venv/lib/python*/site-packages/aiohttp/web_urldispatcher.py < patch/aiohttp310.patch && echo " *** aiohttp Patched!" || echo " *** aiohttp patch failed?")) || ( echo " ***"; echo " *** WE CAN REMOVE THE PATCH FOR aiohttp 3.10.0 from $0"; echo " ***" )
- name: Restore pre-commit environment from cache
id: cache-precommit
uses: actions/cache@v4
Expand DownExpand Up@@ -203,8 +201,6 @@ jobs:
# 20220124 Mimic setup_test.sh
uv pip install --upgrade -r requirements_test.txt -c https://raw.githubusercontent.com/home-assistant/core/dev/homeassistant/package_constraints.txt -r https://raw.githubusercontent.com/home-assistant/core/dev/requirements_test.txt -r https://raw.githubusercontent.com/home-assistant/core/dev/requirements_test_pre_commit.txt
uv pip install --upgrade pytest-asyncio
# TODO: Remove after update of aiohttp beyond 3.10.0
uv pip show aiohttp | grep -q "Version: 3.10.0" && (grep -q "core.locations" venv/lib/python*/site-packages/aiohttp/web_urldispatcher.py && echo " *** aiohttp already patched" || ( echo "Patching aiohttp 3.10.0 for tests"; patch -tRup0 venv/lib/python*/site-packages/aiohttp/web_urldispatcher.py < patch/aiohttp310.patch && echo " *** aiohttp Patched!" || echo " *** aiohttp patch failed?")) || ( echo " ***"; echo " *** WE CAN REMOVE THE PATCH FOR aiohttp 3.10.0 from $0"; echo " ***" )

pytest:
runs-on: ubuntu-latest
Expand DownExpand Up@@ -245,6 +241,8 @@ jobs:
with:
name: coverage-${{ matrix.python-version }}
path: .coverage
if-no-files-found: error
include-hidden-files: true
Comment on lines +244 to +245

@coderabbitaicoderabbitaiBotSep 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the invalid include-hidden-files parameter.

The addition of the if-no-files-found: error parameter looks good as it specifies error handling when no files are found.

However, the include-hidden-files: true parameter is not a valid input for the actions/upload-artifact@v4 action. Please remove it.

Apply this diff to remove the invalid parameter:

- include-hidden-files: true
Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if-no-files-found: error
include-hidden-files: true
if-no-files-found: error
Tools
actionlint

245-245: input "include-hidden-files" is not defined in action "actions/upload-artifact@v4". available inputs are "compression-level", "if-no-files-found", "name", "overwrite", "path", "retention-days"

(action)


mypy:
runs-on: ubuntu-latest
Expand Down