Skip to content

Validate py314 compatibility - #793

Merged
CoMPaTech merged 12 commits into
mainfrom
py314
Oct 8, 2025
Merged

Validate py314 compatibility#793
CoMPaTech merged 12 commits into
mainfrom
py314

Conversation

@CoMPaTech

@CoMPaTechCoMPaTech commented Oct 7, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Official Python 3.14 compatibility added across tooling and project metadata.
  • Tests

    • CI test matrix now includes Python 3.14 alongside 3.13.
    • CI cache handling refined for per-version differentiation; restore steps updated and pytest restore tolerates first-time cache creation.
  • Documentation

    • Added an “Ongoing” changelog entry: validation for Python 3.14.
  • Chores

    • Default Python bumped to 3.14; CI workflow cache versions updated and activation/restore behavior aligned for per-version virtual environments.

@CoMPaTechCoMPaTech added the dependencies Pull requests that update a dependency file label Oct 7, 2025
@CoMPaTech
CoMPaTech requested a review from a team as a code ownerOctober 7, 2025 20:49
@CoMPaTechCoMPaTech added github_actions Pull requests that update Github_actions code python Pull requests that update Python code quality labels Oct 7, 2025
@coderabbitai

coderabbitaiBot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@CoMPaTech has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c38d3e0 and 9f890f4.

📒 Files selected for processing (1)
  • .github/workflows/verify.yml (11 hunks)

Walkthrough

Bump default/supported Python from 3.13 to 3.14 across CI and tooling; add Python 3.14 to the test matrix; increment workflow cache versions; change verify.yml cache-key handling to emit a global/hash key plus a per-version suffix and update venv activation/restore steps to use per-version virtualenv names; update pre-commit/pyproject targets/classifiers; add an “Ongoing” changelog entry for testing Python 3.14.

Changes

Cohort / File(s)Summary of changes
Merge workflow
.github/workflows/merge.yml
DEFAULT_PYTHON bumped 3.133.14; CACHE_VERSION bumped 1011.
Verify workflow
.github/workflows/verify.yml
DEFAULT_PYTHON bumped 3.133.14; test matrix extended to include 3.14; CACHE_VERSION bumped 1416; cache job now emits a global/hash-only cache-key and a python-version output (python-version removed from the global key); restore steps use suffixed key {{ needs.cache.outputs.cache-key }}-{{ needs.cache.outputs.python-version }}; virtualenv activations switch to . venv-${{ needs.cache.outputs.python-version }}/bin/activate; added fail-on-miss: false on a pytest restore step; spacing/formatting and token alignment refinements.
Pre-commit config
.pre-commit-config.yaml
default_language_version for unspecified Python hooks changed from python3.13default.
Project metadata / tools
pyproject.toml
Added Python 3.14 classifier and aligned tool targets/configs (pylint/mypy/ruff target versions) to 3.14.
Changelog
CHANGELOG.md
Added an “Ongoing” entry: “Test/validate for Python 3.14” placed before v1.7.8.

Sequence Diagram(s)

sequenceDiagram
autonumber
participant Runner as GitHub Actions Runner
participant CacheJob as cache job
participant MatrixJob as matrix test job
rect #EEF8F2
Note right of CacheJob: Compute global/hash-only cache key\nOutputs: cache-key, python-version
end
CacheJob-->>Runner: outputs.cache-key\noutputs.python-version
rect #FFF8E6
Note right of MatrixJob: Restore uses suffixed key:\n"${{ needs.cache.outputs.cache-key }}-{{ needs.cache.outputs.python-version }}"\nActivate `. venv-<python-version>/bin/activate`
end
MatrixJob->>CacheJob: request restore with suffixed key
Runner->>MatrixJob: prepare venv, run tests for matrix.python-version
MatrixJob->>Runner: on miss create cache (pytest restore uses fail-on-miss: false)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

pre-commit

Suggested reviewers

  • bouwew

Poem

Thump-thump, I hop and tally code,
3.14 hops in — a brand new road.
Caches split, venvs renamed, tests align,
Linters hum and CI starts to shine.
Carrot crunch — hooray, the checks are fine! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly captures the core objective of the PR—validating compatibility with Python 3.14—directly reflecting the updates to workflows, configurations, and changelog entries introduced in this changeset.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ac821d and 24955d9.

📒 Files selected for processing (1)
  • .github/workflows/verify.yml (10 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CoMPaTech
PR: plugwise/python-plugwise#656
File: .github/workflows/verify.yml:176-176
Timestamp: 2024-11-28T19:48:51.051Z
Learning: In this project, we align our supported Python versions with HA-core. When HA-core moves to a new Python version (e.g., Python 3.13), we update our testing matrix accordingly and discontinue testing for the previous version.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Prepare

Comment thread.github/workflows/verify.yml Outdated

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.pre-commit-config.yaml (1)

2-3: Update the comment to match the new behavior.

With python: default we no longer “force all unspecified python hooks to run python3”, so the comment is now misleading. Please adjust or remove it to avoid confusion.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc99348 and afc914e.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CoMPaTech
PR: plugwise/python-plugwise#656
File: .github/workflows/verify.yml:176-176
Timestamp: 2024-11-28T19:48:51.051Z
Learning: In this project, we align our supported Python versions with HA-core. When HA-core moves to a new Python version (e.g., Python 3.13), we update our testing matrix accordingly and discontinue testing for the previous version.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Prepare

@codecov

codecovBot commented Oct 8, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (12da803) to head (9aed482).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #793 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 21 21 Lines 3388 3388 =========================================
Hits 3388 3388 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@CoMPaTech
CoMPaTech merged commit d20c3f3 into mainOct 8, 2025
39 of 40 checks passed
@CoMPaTech
CoMPaTech deleted the py314 branch October 8, 2025 07:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filegithub_actionsPull requests that update Github_actions codepythonPull requests that update Python codequality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@CoMPaTech