Rename water_heater dicts

[bouwew]

Summary by CodeRabbit

• New Features

  • Standardized boiler and domestic hot-water temperature data under clearer, consistent names.
  • Preserved existing temperature readings, limits, and control behavior.
  • Updated temperature controls to use the standardized data fields.

• Bug Fixes

  • Improved handling of domestic hot-water modes and nested temperature data across heating and cooling configurations.
  • Ensured active temperature controls are recognized consistently across supported devices.

• Tests

  • Updated coverage and sample data to validate consistent temperature handling across supported devices.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR renames boiler and domestic-hot-water temperature fields across the data model, runtime mappings, fixtures, fixture generation, and test data. Legacy actuator processing and nested comparison logic now recognize the new entity keys.

Changes

Temperature schema migration

Layer / File(s)	Summary
Runtime schema and mappings plugwise/common.py, plugwise/constants.py, plugwise/data.py, plugwise/legacy/helper.py, plugwise/smile.py	The runtime model and temperature operations use boiler_temperature and dhw_temperature. Legacy actuator processing no longer excludes the renamed temperature actuator.
Fixture schema and generation fixtures/*/data.json, scripts/manual_fixtures.py	Fixtures and generated fixture data replace the legacy temperature keys while preserving values and limits.
Test data and comparison updates tests/data/{adam,anna}/*.json, tests/test_init.py	Test fixtures use the renamed fields. Nested dictionary comparison recognizes the updated entity keys.
Release metadata pyproject.toml, CHANGELOG.md	The package version changes to 1.14.5. The changelog records the dictionary-key renames.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• plugwise/python-plugwise#888: Modifies the same temperature-field mappings, schemas, fixtures, and tests.
• plugwise/python-plugwise#893: Modifies the shared special-field mappings and legacy Anna temperature handling.
• plugwise/python-plugwise#878: Modifies the same heating fixture and fixture-generation logic.

Suggested reviewers:compatech

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main change: renaming water-heater dictionary fields.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch wh-3

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bb3db5a) to head (acee205).

Additional details and impacted files

@@ Coverage Diff @@## main #908 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 21 21 Lines 3502 3505 +3 =========================================
+ Hits 3502 3505 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugwise/constants.py`:
- Around line 595-596: Remove the unused maximum_boiler_temperature and
max_dhw_temperature fields from GwEntityData, leaving boiler_temperature and
dhw_temperature intact. Do not alter the corresponding ActuatorType members,
legacy constants, or test strings unless required by an explicit
deprecated-alias contract.
In `@plugwise/smile.py`:
- Around line 178-181: Update the positive actuator inputs in
tinker_actuator_temp() to use boiler_temperature and dhw_temperature, matching
the public keys handled by set_number(). Replace maximum_boiler_temperature and
max_dhw_temperature while preserving the existing assertions and test flow.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 94673460-ce2e-4cef-b951-ae94b637126b

📥 Commits

Reviewing files that changed from the base of the PR and between 8b41c85 and 1f42d6c.

📒 Files selected for processing (57)

• fixtures/adam_bad_thermostat/data.json
• fixtures/adam_heatpump_cooling/data.json
• fixtures/adam_jip/data.json
• fixtures/adam_onoff_cooling_fake_firmware/data.json
• fixtures/adam_plus_anna/data.json
• fixtures/adam_plus_anna_new/data.json
• fixtures/adam_plus_anna_new_regulation_off/data.json
• fixtures/anna_elga_2_cooling/data.json
• fixtures/anna_elga_2_schedule_off/data.json
• fixtures/anna_elga_no_cooling/data.json
• fixtures/anna_heatpump_cooling/data.json
• fixtures/anna_heatpump_cooling_fake_firmware/data.json
• fixtures/anna_heatpump_heating/data.json
• fixtures/anna_loria_cooling_active/data.json
• fixtures/anna_loria_driessens/data.json
• fixtures/anna_loria_heating_idle/data.json
• fixtures/anna_v4/data.json
• fixtures/anna_v4_dhw/data.json
• fixtures/anna_v4_no_tag/data.json
• fixtures/legacy_anna/data.json
• fixtures/legacy_anna_2/data.json
• fixtures/m_adam_cooling/data.json
• fixtures/m_adam_heating/data.json
• fixtures/m_adam_heating_off_schedule/data.json
• fixtures/m_adam_jip/data.json
• fixtures/m_anna_heatpump_cooling/data.json
• fixtures/m_anna_heatpump_idle/data.json
• plugwise/common.py
• plugwise/constants.py
• plugwise/data.py
• plugwise/smile.py
• scripts/manual_fixtures.py
• tests/data/adam/adam_bad_thermostat.json
• tests/data/adam/adam_heatpump_cooling.json
• tests/data/adam/adam_jip.json
• tests/data/adam/adam_onoff_cooling_fake_firmware.json
• tests/data/adam/adam_plus_anna.json
• tests/data/adam/adam_plus_anna_new.json
• tests/data/adam/adam_plus_anna_new_regulation_off.json
• tests/data/anna/anna_elga_2_cooling.json
• tests/data/anna/anna_elga_2_cooling_UPDATED_DATA.json
• tests/data/anna/anna_elga_2_schedule_off.json
• tests/data/anna/anna_elga_no_cooling.json
• tests/data/anna/anna_heatpump_cooling.json
• tests/data/anna/anna_heatpump_cooling_fake_firmware.json
• tests/data/anna/anna_heatpump_heating.json
• tests/data/anna/anna_heatpump_heating_UPDATED_DATA.json
• tests/data/anna/anna_loria_cooling_active.json
• tests/data/anna/anna_loria_driessens.json
• tests/data/anna/anna_loria_heating_idle.json
• tests/data/anna/anna_v4.json
• tests/data/anna/anna_v4_UPDATED_DATA.json
• tests/data/anna/anna_v4_dhw.json
• tests/data/anna/anna_v4_no_tag.json
• tests/data/anna/legacy_anna.json
• tests/data/anna/legacy_anna_2.json
• tests/test_init.py

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud