Fix Core Issue #178699 by bouwew · Pull Request #914 · plugwise/python-plugwise

bouwew · 2026-08-11T10:39:42Z

Summary by CodeRabbit

New Features
- Added support for domestic hot water comfort switches.
- Comfort switches now appear and function as toggle controls on compatible systems.
- Preserves available actuator-derived hot water modes.
Bug Fixes
- Prevented valid hot water modes from being overwritten.
- Improved validation feedback by identifying invalid operating modes and schedule states.
Documentation
- Added release notes documenting these improvements.

coderabbitai · 2026-08-11T10:39:58Z

Warning

Review limit reached

@bouwew, you've reached your PR review limit, so we couldn't start this review.

Next review available in:37 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f1390e8d-ff4a-4eea-b70c-89bf647d6efd

📥 Commits

Reviewing files that changed from the base of the PR and between d42d800 and 429ae0a.

📒 Files selected for processing (3)

CHANGELOG.md
plugwise/legacy/smile.py
plugwise/smile.py

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e8bd5fe9-13c6-4e95-b69c-29b2d4b1e879

📥 Commits

Reviewing files that changed from the base of the PR and between 53ea602 and d42d800.

📒 Files selected for processing (2)

CHANGELOG.md
pyproject.toml

📝 Walkthrough

Walkthrough

The change restores dhw_cm_switch support, preserves actuator-derived domestic hot water modes, updates mode validation sources and error details, and records version 1.14.6.

Changes

Domestic hot water mode handling

Layer / File(s)	Summary
Restore comfort-switch mapping `plugwise/smile.py`, `plugwise/helper.py`	`dhw_cm_switch` maps to the domestic hot water comfort-mode toggle. Fallback modes no longer replace actuator-derived modes.
Update mode validation and release metadata `plugwise/smile.py`, `pyproject.toml`, `CHANGELOG.md`	DHW, gateway, and regulation validation uses modes exposed by gateway entities. Invalid values appear in validation errors. The package version and changelog update to `1.14.6`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

plugwise/python-plugwise#905: Both changes update DHW mode handling and validation in plugwise/smile.py.
plugwise/python-plugwise#771: Both changes modify DHW mode-selection logic in plugwise/helper.py.

Suggested labels:quality, enhancement, python

Suggested reviewers:compatech

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the primary change: fixes for Home Assistant Core issue `#178699`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-178699

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 5: Update the changelog entry to replace the misspelled “confort” with
“comfort,” leaving the rest of the entry unchanged.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c7e57cc-7277-4287-8391-d7c0f543d6b4

📥 Commits

Reviewing files that changed from the base of the PR and between 607ac48 and 77e0503.

📒 Files selected for processing (2)

CHANGELOG.md
plugwise/smile.py

codecov · 2026-08-11T10:41:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (607ac48) to head (429ae0a).

Additional details and impacted files

@@ Coverage Diff @@## main #914 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 21 21 Lines 3505 3506 +1 =========================================
+ Hits 3505 3506 +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugwise/smile.py`:
- Around line 271-277: Update the validation checks in the methods handling dhw,
gateway, and regulation modes to safely handle missing optional collections by
using an empty-list fallback before membership tests. Preserve the existing
PlugwiseError behavior for unsupported modes or invalid lengths, and apply this
consistently to dhw_modes, gateway_modes, and regulation_modes.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a1ef5b94-c79c-4b53-a5df-6188e00720e7

📥 Commits

Reviewing files that changed from the base of the PR and between 807d146 and 53ea602.

📒 Files selected for processing (2)

plugwise/helper.py
plugwise/smile.py

sonarqubecloud · 2026-08-12T06:01:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bouwew added 2 commits August 11, 2026 12:33

Fix dhw_cm_switch not working
73fe58d

Update CHANGELOG
77e0503

coderabbitaiBot requested a review from CoMPaTech August 11, 2026 10:40

coderabbitaiBot added enhancement New feature or request python Pull requests that update Python code labels Aug 11, 2026

coderabbitaiBot requested changes Aug 11, 2026
View reviewed changes

Comment threadCHANGELOG.md Outdated

bouwew deployed to testpypi August 11, 2026 10:41 — with GitHub Actions Active

coderabbitaiBot removed enhancement New feature or request python Pull requests that update Python code labels Aug 11, 2026

bouwew deployed to testpypi August 11, 2026 13:52 — with GitHub Actions Active

Guard for overwriting _dhw_allowed_modes
1c7a8b9

bouwew force-pushed the fix-178699 branch from 807d146 to 1c7a8b9Compare August 11, 2026 14:21

bouwew deployed to testpypi August 11, 2026 14:23 — with GitHub Actions Active

bouwew added 2 commits August 11, 2026 18:18

Replace internal variables with data in output, improve raise messages
ccb10ec

Ruffed
53ea602

coderabbitaiBot added enhancement New feature or request python Pull requests that update Python code labels Aug 11, 2026

Update CHANGELOG
a39e30b

coderabbitaiBot requested changes Aug 11, 2026
View reviewed changes

Comment threadplugwise/smile.py Outdated

bouwew deployed to testpypi August 11, 2026 16:59 — with GitHub Actions Active

Set to v1.14.6 release-version
d42d800

coderabbitaiBot added the quality label Aug 12, 2026

Fix typo as suggested
f2ec651

bouwew deployed to testpypi August 12, 2026 05:47 — with GitHub Actions Active

bouwew added 2 commits August 12, 2026 07:50

Handle absent mode collections before validation as suggested
d56cd03

More raise-message improvements
429ae0a

coderabbitaiBot approved these changes Aug 12, 2026
View reviewed changes

bouwew deployed to testpypi August 12, 2026 06:03 — with GitHub Actions Active

bouwew marked this pull request as ready for review August 12, 2026 06:05

bouwew requested a review from a team as a code owner August 12, 2026 06:05

bouwew merged commit ccd5387 into mainAug 12, 2026
18 checks passed

bouwew deleted the fix-178699 branch August 12, 2026 06:10

bouwew deployed to pypi August 12, 2026 06:10 — with GitHub Actions Active

Navigation Menu

Uh oh!

Fix Core Issue #178699 - #914

Fix Core Issue #178699#914
bouwew merged 10 commits into
mainfrom
fix-178699

bouwew commented Aug 11, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Aug 11, 2026•
edited
Loading

Review limit reached

Walkthrough

Changes

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

codecovBot commented Aug 11, 2026•
edited
Loading

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

sonarqubecloudBot commented Aug 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

bouwew commented Aug 11, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Aug 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecovBot commented Aug 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloudBot commented Aug 12, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

bouwew commented Aug 11, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Aug 11, 2026•
edited
Loading

codecovBot commented Aug 11, 2026•
edited
Loading