Skip to content

enhance: support more types when deducing, and fix bugs - #158

Merged
jianzs merged 5 commits into
pluto-lang:feat-support-pythonfrom
jianzs:feat-python-support
Mar 21, 2024
Merged

enhance: support more types when deducing, and fix bugs#158
jianzs merged 5 commits into
pluto-lang:feat-support-pythonfrom
jianzs:feat-python-support

Conversation

@jianzs

Copy link
Copy Markdown
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix#123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

  • CLI
  • Pyright Deudcer

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
  • Fix a bug that the local variables within a class's member are incorrectly identified as needing extraction. This issue arises because the class node and its members are at the same scope level. We cannot confirm whether the variables within a class member are located within the class scope.
  • Fix a bug in dumping the Pluto project configuration to a configuration file, where it incorrectly includes some information that should not be included, such as the state attribute of the stack.
  • Add support for dictionaries, lists, and tuples types when extracting codes and evaluating values. This feature is useful when users need to add custom configurations to infrastructure resources, such as environment variables.
  • Include the dist-info directory of Python packages when extracting dependencies.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…ass member
The issue arises due to the class node and its members being at the same scope level. We can't verify whether the variables within a class member are located within the class scope.
…racting codes and evaluating values
Dictionaries can be used as custom arguments in the constructor call, including user-defined environment variables.
@jianzsjianzs added deducer Deducer cli command-line interface labels Mar 21, 2024
@jianzs
jianzs requested a review from PeefyMarch 21, 2024 12:34
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3599009

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PeefyPeefy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@jianzs
jianzs merged commit c99b235 into pluto-lang:feat-support-pythonMar 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clicommand-line interfacededucerDeducer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jianzs@Peefy