Skip to content

fix(generator): failed to generate iac code due to missing type information in webpack - #169

Merged
Peefy merged 1 commit into
pluto-lang:mainfrom
jianzs:fix-generate-dot
Apr 2, 2024
Merged

fix(generator): failed to generate iac code due to missing type information in webpack#169
Peefy merged 1 commit into
pluto-lang:mainfrom
jianzs:fix-generate-dot

Conversation

@jianzs

@jianzsjianzs commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix#123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • Generator
  • Base SDK

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@jianzsjianzs added the generator Generator label Apr 2, 2024
@changeset-bot

changeset-botBot commented Apr 2, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8819258

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
NameType
@plutolang/static-generatorPatch
@plutolang/basePatch
@plutolang/cliPatch
@plutolang/pulumi-adapterPatch
@plutolang/simulator-adapterPatch
@plutolang/pyright-deducerPatch
@plutolang/static-deducerPatch
@plutolang/graphviz-generatorPatch
@plutolang/pluto-infraPatch
@plutolang/plutoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jianzs
jianzs requested a review from PeefyApril 2, 2024 03:20

@PeefyPeefy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Peefy merged commit 108c1b9 into pluto-lang:mainApr 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generatorGenerator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jianzs@Peefy