Skip to content

fix: resolve topo sort failure by adding missing resource edge - #291

Merged
jianzs merged 1 commit into
pluto-lang:mainfrom
jianzs:fix-resource-dep
Jul 17, 2024
Merged

fix: resolve topo sort failure by adding missing resource edge#291
jianzs merged 1 commit into
pluto-lang:mainfrom
jianzs:fix-resource-dep

Conversation

@jianzs

Copy link
Copy Markdown
Contributor

The topological sort was wrong due to a missing edge related to the resource argument. This commit adds the required edge to ensure correct sorting order.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix#123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • Base SDK
  • Graphviz Generator

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The topological sort was wrong due to a missing edge related to the resource argument. This commit adds the required edge to ensure correct sorting order.
@jianzsjianzs added bug Something isn't working generator Generator sdk Client SDK and Infra SDK labels Jul 17, 2024
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c016e15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
NameType
@plutolang/graphviz-generatorPatch
@plutolang/basePatch
@plutolang/cliPatch
@plutolang/pulumi-adapterPatch
@plutolang/simulator-adapterPatch
@plutolang/pyright-deducerPatch
@plutolang/static-deducerPatch
@plutolang/static-generatorPatch
@plutolang/pluto-infraPatch
@plutolang/plutoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jianzs
jianzs merged commit 8f0e48d into pluto-lang:mainJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workinggeneratorGeneratorsdkClient SDK and Infra SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jianzs