Skip to content

feat(sdk): add no-op infrastructure API to client SDK - #310

Merged
jianzs merged 1 commit into
pluto-lang:mainfrom
jianzs:feat-noop-infra-api
Aug 1, 2024
Merged

feat(sdk): add no-op infrastructure API to client SDK#310
jianzs merged 1 commit into
pluto-lang:mainfrom
jianzs:feat-noop-infra-api

Conversation

@jianzs

Copy link
Copy Markdown
Contributor

To prevent runtime errors, a no-op (no operation) implementation of the infrastructure API has been introduced in the client SDK. This ensures that when pytest is run locally, calls to the infrastructure API do not result in errors.

Future plans may involve bundling the entire user code, not just the business logic, which further necessitates a no-op infrastructure API in the SDK to avoid runtime exceptions.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix#123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • Python SDK

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@jianzsjianzs added the sdk Client SDK and Infra SDK label Aug 1, 2024
@changeset-bot

changeset-botBot commented Aug 1, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d21b253

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jianzs
jianzsforce-pushed the feat-noop-infra-api branch from bfeabc7 to 00e5162CompareAugust 1, 2024 03:46
To prevent runtime errors, a no-op (no operation) implementation of the infrastructure API has been introduced in the client SDK. This ensures that when pytest is run locally, calls to the infrastructure API do not result in errors.
Future plans may involve bundling the entire user code, not just the business logic, which further necessitates a no-op infrastructure API in the SDK to avoid runtime exceptions.
@jianzs
jianzsforce-pushed the feat-noop-infra-api branch from 00e5162 to d21b253CompareAugust 1, 2024 04:03
@jianzs
jianzs requested a review from PeefyAugust 1, 2024 04:09

@PeefyPeefy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianzs
jianzs merged commit 0dc407e into pluto-lang:mainAug 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdkClient SDK and Infra SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jianzs@Peefy