Skip to content

fix(deducer): use package name from dist-info instead of import name - #325

Merged
jianzs merged 1 commit into
pluto-lang:mainfrom
jianzs:fix-pkg-name-error
Aug 7, 2024
Merged

fix(deducer): use package name from dist-info instead of import name#325
jianzs merged 1 commit into
pluto-lang:mainfrom
jianzs:fix-pkg-name-error

Conversation

@jianzs

Copy link
Copy Markdown
Contributor

The package import name may differ from its actual package name. For instance, pysqlite3-binary is the package name, but it is imported as pysqlite3. This mismatch can cause the loss of required packages at runtime.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix#123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • Pyright Deudcer

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The package import name may differ from its actual package name. For instance, `pysqlite3-binary` is the package name, but it is imported as `pysqlite3`. This mismatch can cause the loss of required packages at runtime.
@jianzsjianzs added bug Something isn't working deducer Deducer labels Aug 7, 2024
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bc501ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@plutolang/pyright-deducerPatch
@plutolang/cliPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jianzs
jianzs merged commit c1c732e into pluto-lang:mainAug 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingdeducerDeducer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jianzs