Refactor/monorepo (WIP) - #561
Open
pmb0 wants to merge 5 commits into
Open
Conversation
| } | ||
| } | ||
| function updateTsConfig(workspaceDir: string, lockfile: LockfileFile) { |
There was a problem hiding this comment.
Function updateTsConfig has 32 lines of code (exceeds 25 allowed). Consider refactoring.
| } | ||
| export function createAxiosError<T>( | ||
| name: string, |
There was a problem hiding this comment.
Function createAxiosError has 5 arguments (exceeds 4 allowed). Consider refactoring.
| } | ||
| export function mockNextResponseAsError( | ||
| name: string, |
There was a problem hiding this comment.
Function mockNextResponseAsError has 5 arguments (exceeds 4 allowed). Consider refactoring.
BREAKING CHANGE: Images adapters must now be installed separately: - @edged/fs-adapter - @edged/http-adapter - @edged/s3-adapter
pmb0force-pushed
the
refactor/monorepo
branch
from
September 11, 2021 11:20
6a7f3dd to
6fc1bf6Compare| } | ||
| } | ||
| function updateTsConfig(workspaceDir: string, lockfile: LockfileFile) { |
There was a problem hiding this comment.
Function updateTsConfig has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Code Climate has analyzed commit 1338696 and detected 11 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.