Skip to content

Autofocus effect - #192

Merged
abernier merged 5 commits into
pmndrs:masterfrom
abernier:abernier/autofocus
May 2, 2023
Merged

Autofocus effect#192
abernier merged 5 commits into
pmndrs:masterfrom
abernier:abernier/autofocus

Conversation

@abernier

@abernierabernier commented Apr 30, 2023

Copy link
Copy Markdown
Member

Note Merged
see <Autofocus> doc

Based on @ektogamatwork and pmndrs/postprocessing DepthOfFieldEffect, <Autofocus> effect extends <DepthOfField> and drives its target.

autofocus-suzi-v2.mov

Demo here: https://codesandbox.io/s/dfw6w4?file=/src/Autofocus.tsx

  • Documentation updated
  • Ready to merge

@ektogamat

Copy link
Copy Markdown
Contributor

Great work my friend. Happy that this will become official 😊✌🏻

Comment threadsrc/Autofocus.tsx Outdated
@v1rtl

Copy link
Copy Markdown
Member

Could you please add a page to docs/effects instead of README?

@v1rtl
v1rtl requested a review from drcmdaApril 30, 2023 11:50
@abernierabernier mentioned this pull request Apr 30, 2023
3 tasks
Comment threadsrc/Autofocus.tsx
@ektogamat

Copy link
Copy Markdown
Contributor

Can I help with something? Documentation maybe? I have no idea how to contribute hehehe. Just want to be useful if needed, okay? 🫶🏻

Comment threadsrc/Autofocus.tsx
Comment threadsrc/Autofocus.tsx Outdated
Comment threadsrc/Autofocus.tsx Outdated
@abernier
abernierforce-pushed the abernier/autofocus branch 2 times, most recently from 84be37b to 3ca723aCompareMay 2, 2023 07:29
@abernier
abernierforce-pushed the abernier/autofocus branch from 3ca723a to ee87945CompareMay 2, 2023 07:30
@abernier
abernier requested a review from drcmdaMay 2, 2023 07:36
@abernier
abernier marked this pull request as draft May 2, 2023 11:30
@abernier
abernier marked this pull request as ready for review May 2, 2023 14:56
@abernier
abernier merged commit 9d1f77e into pmndrs:masterMay 2, 2023
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ektogamat

Copy link
Copy Markdown
Contributor

AMAZING WORK GUYS 👏🏻👏🏻👏🏻🫶🏻

@abernier
abernier deleted the abernier/autofocus branch May 2, 2023 17:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abernier@ektogamat@v1rtl@drcmda