Skip to content

feat: HBAO + SSGI + TRAA + MotionBlur - #211

Open
CodyJasonBennett wants to merge 13 commits into
pmndrs:masterfrom
CodyJasonBennett:feat/ssgi
Open

feat: HBAO + SSGI + TRAA + MotionBlur#211
CodyJasonBennett wants to merge 13 commits into
pmndrs:masterfrom
CodyJasonBennett:feat/ssgi

Conversation

@CodyJasonBennett

@CodyJasonBennettCodyJasonBennett commented May 23, 2023

Copy link
Copy Markdown
Contributor

Implements #183
Implements 0beqz/realism-effects#5

Follows up #210 by adding HBAO + SSGI + TRAA + MotionBlur passes from 0beqz/realism-effects.

<EffectComposerdisableNormalPassmultisampling={0}><HBAO/> // Note: this is a component of SSGI and thus redundant
<SSGI/><TRAA/><MotionBlur/></EffectComposer>

https://codesandbox.io/s/c143do

image

Comment threadsrc/effects/SSGI.tsx Outdated
Comment threadsrc/effects/SSGI.tsx Outdated
@CodyJasonBennettCodyJasonBennett changed the title feat: SSGIfeat: SSGI + TRAAMay 24, 2023
@CodyJasonBennettCodyJasonBennett changed the title feat: SSGI + TRAAfeat: SSGI + TRAA + MotionBlurMay 24, 2023
@CodyJasonBennettCodyJasonBennett changed the title feat: SSGI + TRAA + MotionBlurfeat: HBAO + SSGI + TRAA + MotionBlurMay 24, 2023
@v1rtl

Copy link
Copy Markdown
Member

@CodyJasonBennett there's merge conflicts, also safe to merge after?

@CodyJasonBennett

CodyJasonBennett commented May 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Can clear those in a moment. Need to do integration testing still, but it could be worthwhile to wait until 0beqz updates SSGI as it dramatically reduces memory usage and smearing. Need to also see if there's a diffuse-only or specular-only (SSR) GI and whether we can combine his effects at all. I get a broken render when combining all into an effectpass as per his readme.

@dswhy

Copy link
Copy Markdown

Any estimation on when this could be available? I would really love to use the motion blur :D

@kitaedesigns

Copy link
Copy Markdown

Wow I cannot wait for this merge! 🤤

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@CodyJasonBennett@v1rtl@dswhy@kitaedesigns@drcmda