Skip to content

fix(EffectComposer): don't merge when convolution is head#250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodyJasonBennett merged 1 commit into from
Oct 24, 2023
Merged

fix(EffectComposer): don't merge when convolution is head #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/EffectComposer.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,11 +141,13 @@ export const EffectComposer = React.memo(
if (child instanceof Effect) {
const effects: Effect[] = [child]

let next: unknown = null
while ((next = children[i + 1]) instanceof Effect) {
if (isConvolution(next)) break
effects.push(next)
i++
if (!isConvolution(child)) {
let next: unknown = null
while ((next = children[i + 1]) instanceof Effect) {
if (isConvolution(next)) break
effects.push(next)
i++
}
}

const pass = new EffectPass(camera, ...effects)
Expand Down