Skip to content

fix: set composer size to current canvas output size#341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcu13321 wants to merge 1 commit into
base:master
Choose a base branch
from
Open

fix: set composer size to current canvas output size #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/EffectComposer.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { TextureDataType, Group, Camera, Scene } from 'three'
import { HalfFloatType, NoToneMapping } from 'three'
import { HalfFloatType, NoToneMapping, Vector2 } from 'three'
import {
type JSX,
memo,
Expand DownExpand Up@@ -51,6 +51,8 @@ export type EffectComposerProps = {
const isConvolution = (effect: Effect): boolean =>
(effect.getAttributes() & EffectAttribute.CONVOLUTION) === EffectAttribute.CONVOLUTION

const glSize = new Vector2()

export const EffectComposer = /* @__PURE__ */ memo(
/* @__PURE__ */ forwardRef<EffectComposerImpl, EffectComposerProps>(
(
Expand DownExpand Up@@ -113,7 +115,9 @@ export const EffectComposer = /* @__PURE__ */ memo(
resolutionScale,
])

useEffect(() => composer?.setSize(size.width, size.height), [composer, size])
gl.getSize(glSize)

useEffect(() => composer.setSize(glSize.width, glSize.height), [composer, glSize.width, glSize.height])
useFrame(
(_, delta) => {
if (enabled) {
Expand Down