feat(rust): Implement Collection for multi-source data management - #8
feat(rust): Implement Collection for multi-source data management#8google-labs-jules[bot] wants to merge 2 commits into
Conversation
This commit adds a `Collection` struct that provides a unified view over multiple data sources, backed by the `BufferPool` for efficient caching. A `DataSource` struct is introduced to wrap raw data and define the `stride` for paging. The `Collection` is initialized with a list of these sources, chunks the data into pages, and loads them into a `FramePool`. The `Collection` implements a `get()` method for indexed access and the `Iterator` trait for seamless iteration, with the `BufferPool` handling data loading and caching transparently. Comprehensive integration tests are included to validate the new functionality.
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
This change introduces a
Collectionstruct in the Rust implementation to provide a unified, indexable, and iterable view over multiple data sources.Key features include:
DataSourcestruct: Encapsulates a data vector and astrideto define how data is paged.Collectionstruct: Manages multipleDataSources, using the existingBufferPoolfor efficient, cached access to the underlying data. It chunks data from each source into pages and loads them into aFramePool.get()method allows retrieving any item by its global index, transparently handling page loads.Collectionimplements theIteratortrait, enabling seamless iteration over all items across all sources with theBufferPoolmanaging caching in the background.Integration tests have been added to verify the functionality, including initialization, indexed access, and iteration, ensuring the implementation is robust and correct.
PR created automatically by Jules for task 2033158566486310994