Uh oh!
There was an error while loading. Please reload this page.
Fix: Improve Git transport integrity and fix transaction filter panic - #2
Open
mertcano wants to merge 1 commit into
Open
Fix: Improve Git transport integrity and fix transaction filter panic#2mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
### Description This PR secures dependency resolution and resolves a runtime panic path in the transaction filtering logic of the `op-rbuilder` crate[cite: 41, 48]. ### Key Changes * **Git Transport Integrity (`Cargo.toml`):** Changed the `rollup-boost` source to an HTTPS URL with an immutable Git revision (`rev = "64be33fccdbe8b6c99118b5395a3949c7b73ae4c"`) to prevent transport downgrades and moving-target dependency resolution[cite: 41, 47]. * **Production Panic Prevention (`src/builders/context.rs`):** Replaced an unchecked `reverted_hashes.unwrap()` call with `Option::is_some_and` during transaction filtering[cite: 41, 48]. This preserves bundle semantics while eliminating a panic path for malformed or unexpectedly absent optional state[cite: 41, 48].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR secures dependency resolution and resolves a runtime panic path in the transaction filtering logic of the
op-rbuildercrate[cite: 41, 48].Key Changes
Cargo.toml): Changed therollup-boostsource to an HTTPS URL with an immutable Git revision (rev = "64be33fccdbe8b6c99118b5395a3949c7b73ae4c") to prevent transport downgrades and moving-target dependency resolution[cite: 41, 47].src/builders/context.rs): Replaced an uncheckedreverted_hashes.unwrap()call withOption::is_some_andduring transaction filtering[cite: 41, 48]. This preserves bundle semantics while eliminating a panic path for malformed or unexpectedly absent optional state[cite: 41, 48].