Uh oh!
There was an error while loading. Please reload this page.
fix(ts-sdk): drop delisted markets on reconnect - #285
Open
worlldz wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Out-of-order concurrent seed responses can restore a delisted market.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| for (const id of fromCache) if (!fresh.has(id)) { byId.delete(id); orderIndex.delete(id); } | ||
| fromCache.clear(); | ||
| markets.forEach((m, i) => { orderIndex.set(m.id, i); byId.set(m.id, { ...byId.get(m.id), ...m }); }); | ||
| for (const id of staticIds) if (!fresh.has(id)) { byId.delete(id); orderIndex.delete(id); } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
marketsSourcecleared its set of cache-seeded IDs after the first REST response and never repopulated it. A market delisted later therefore survived every reconnect seed inbyIdand remained visible for the lifetime of the client.The regression test covers the initial seed, the duplicate cold-open seed, and a later reconnect whose static list no longer contains one market.
Verification
npm run typechecknpm test— 12 files, 143 testsnpm run build