Uh oh!
There was an error while loading. Please reload this page.
WIP - Updating name and documentation for Transparent HelloWorld Service - #189
WIP - Updating name and documentation for Transparent HelloWorld Service#189frisso wants to merge 6 commits into
Conversation
goldenrye
left a comment
There was a problem hiding this comment.
tr-helloworld looks more aesthetic than trhelloworld IMO.
frisso
commented
Jul 26, 2019
Let's try; I remember something like the "-" character creates troubles with the code generation :-( |
goldenrye
commented
Jul 26, 2019
Yes looks swagger auto-gem compiler has problem to generate correct code if there is "-" character, the character following the "-" will be used to generate variable but some place capital some place small-case and code won't be compiled. |
| } | ||
| default PASS; | ||
| description "Action performed on ingress packets"; | ||
| description "Action performed on ingress packets (DROP/PASS/SLOWPATH; default: PASS)"; |
There was a problem hiding this comment.
I think information about possible values and default should not be part of the description.
Maybe the help generation could be improved to include this.
There was a problem hiding this comment.
Right point, Mauricio. Moved now in the "example" section of the YANG. However, the example is not printed on screen by the help, so we should probably modify the command line to include that as well.
mauriciovasquezbernal
commented
Jul 26, 2019
Few comments:
|
6edf5aa to
72d0300Compare
Unfortunately this is not true. Long names are consuming a lot of space on the screen. |
mauriciovasquezbernal
commented
Jul 27, 2019
I soft agree with that, just find a name that is shorter but still meaningful, I think |
Signed-off-by: Fulvio Risso <fulvio.risso@polito.it>
Signed-off-by: Fulvio Risso <fulvio.risso@polito.it>
Added documentation, useful for new developers.
It would be nice to shorten the name, so that we can avoid typing "transparenthelloworld" such as in
polycubectl transparenthelloworld add trhw0but I'm unable to do so right now.