Add WithPadding for independent top and bottom banner padding - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
WithPadding(top, bottom int)so callers can set top and bottom banner padding independently. KeepsWithZeroPadding()as a compatibility wrapper forWithPadding(0, 0). Closes#8.What's new
WithPadding(top, bottom int)sets the number of leading and trailing newlines separately.WithZeroPadding()now delegates toWithPadding(0, 0)and continues to disable the default top padding.Banner.BottomPaddingholds the trailing newline count and is applied inCmdBanner.Behavior changes / guardrails
Banner.TopPaddingchanged frombooltointto support multiple leading newlines; existing callers using the functional options are unaffected.NewCmdBannerdefaults toTopPadding: 1andBottomPadding: 0, preserving the previous single-leading-newline default.for i := 0; i < nsemantics), so callers should pass non-negative integers.Testing
banner_test.gowith tests for default padding,WithPadding, top padding, bottom padding, and zero padding.go test ./...,go vet ./..., andgo fmt ./...are all green.