Uh oh!
There was an error while loading. Please reload this page.
feat: rust implementation - #19
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| } | ||
| #[test] | ||
| fn post_method() { |
There was a problem hiding this comment.
This could use some form_data tests
| mod get; | ||
| mod post; | ||
| pub fn get_client() -> PolywrapClient { |
There was a problem hiding this comment.
I like that we can now use the Rust client and don't have to rely on the JS client for rust wrappers.
Though, I think for most cases we could just mock the subinvocations(if any) and have unit tests instead of e2e
Uh oh!
There was an error while loading. Please reload this page.
| #[plugin_impl] | ||
| impl Module for HttpPlugin { | ||
| fn get( |
There was a problem hiding this comment.
In general for wrappers (like we talked about on the call), I'd love to see more unit tests where we mock the deps (e.g. the subinvocations or in this case the network call).
This not only helps us test the code more thoroughly and without the client dep, but also I find it helps while developing.
No description provided.