Uh oh!
There was an error while loading. Please reload this page.
docs: explain traffic drain gap after SIGTERM - #451
Open
jackowfish wants to merge 2 commits into
Open
Conversation
Contributor
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our zero-downtime docs told web services to fail the health check on
SIGTERMand then close the server, which reads as "stop accepting connections right away."I added a short section explaining the underlying mechanism of EndpointSlice updates.
Routing updates in the background, so requests keep landing for at least 1 to 5 seconds after the health check starts failing, and
SIGTERMhas no fixed ordering against that.The guidance now says to keep serving through a drain window while draining what you already hold.