Skip to content

mutex.h: Update for MSC 1938 compat - #97

Closed
johnwparent wants to merge 1 commit into
potassco:masterfrom
johnwparent:windows/fixup-msc-1938-compat
Closed

mutex.h: Update for MSC 1938 compat#97
johnwparent wants to merge 1 commit into
potassco:masterfrom
johnwparent:windows/fixup-msc-1938-compat

Conversation

@johnwparent

Copy link
Copy Markdown

MSC 1938 removes native_handle from the API.
Remove reference in mutex.h

MSC 1938 removes `native_handle` from the API.
Remove reference in mutex.h
@BenKaufmann

Copy link
Copy Markdown
Contributor

@johnwparent Thank you for making me aware of this issue 👍

This is truly a weird API break from MS, which judging from microsoft/STL#3770 (comment) and https://learn.microsoft.com/en-us/cpp/standard-library/mutex-class-stl?view=msvc-170#native_handle they also forgot to document 😞

However, given that according to C++ standard these members are indeed optional, I pushed a more general fix to clasp's dev branch, which is the branch were development happens.

@johnwparent

Copy link
Copy Markdown
Author

@BenKaufmann Thanks for merging in a fix!

This is truly a weird API break from MS
Thoroughly perplexing choice on the part of MS, particularly considering how devoted to backwards compat they typically are. Thankfully it was such a break it was pretty easy to find.

Apologies for the patch, should have just gone with the generic "re-implementation", didn't realize that parts of Clasp depend on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants