Replace active print statements with logging to stdout. - #3
Open
nofeet wants to merge 1 commit into
Open
Conversation
The new logging statements should look the same as print but with the ability to change the handler and redirect logging messages elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your work on this package. It is quite useful.
I'd like to create log files for it, and I think it would be helpful to capture all the messages that are currently output using print statements. So I replaced all the active print statements with logging ones.
I configured them to print to the stdout so that the output looks the same out of the box. But now users have the ability to configure the ESME and SMSC logging by using the logger names
smpp.esmeandsmpp.smscrespectively.