Make some ESME and SMSC methods a little less private. - #4
Open
nofeet wants to merge 1 commit into
Open
Conversation
ESME and SMSC use name mangling to add extra privacy to some methods. This makes them harder to subclass, which is frequently needed. (e.g., see SMSC's constructor which needs ESME's receiver method) This commit switches to single-underscore versions of all the double-underscore methods. It keeps the old double-underscore versions for backwards compatibility but adds a DeprecationWarning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESME and SMSC use name mangling to add extra privacy to some methods.
This makes them harder to subclass, which is frequently needed.
(e.g., see SMSC's constructor which needs ESME's receiver method)
This commit switches to single-underscore versions of all the
double-underscore methods. It keeps the old double-underscore
versions for backwards compatibility but adds a DeprecationWarning.
For some more thoughts on "name mangling":
https://stackoverflow.com/questions/7456807/python-name-mangling-when-in-doubt-do-what