Uh oh!
There was an error while loading. Please reload this page.
Conversation
asottile
marked this pull request as ready for review
October 28, 2023 18:35
Samyak2 added a commit
to browser-history/browser-history
that referenced
this pull request
May 5, 2024
See pre-commit/pre-commit#3042 Not sure what's the best way forward here
EwoutH
commented
Aug 21, 2024
I don't know if you want to do at this stage, but if you want you could support Python 3.8 again: |
EwoutH added a commit
to EwoutH/solara
that referenced
this pull request
Aug 21, 2024
Python 3.9 is the lowest version pre-commit supports. See pre-commit/pre-commit#3042
asottile
commented
Aug 21, 2024
MemberAuthor
I'm not, but it's good to see that I was right all along |
maartenbreddels pushed a commit
to widgetti/solara
that referenced
this pull request
Aug 23, 2024
* pre-commit: Add pyupgrade pyupgrade ensures the latest Python syntax supported is used. * Run pre-commit check yaml...............................................................Passed fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing packages/solara-widget-manager8/tsconfig.json Fixing packages/solara-widget-manager8/src Fixing packages/solara-widget-manager8/style trim trailing whitespace.................................................Passed pyupgrade................................................................Failed - hook id: pyupgrade - exit code: 1 - files were modified by this hook Rewriting solara/website/pages/doc_use_download.py codespell................................................................Passed ruff.....................................................................Passed ruff-format..............................................................Passed mypy.....................................................................Passed * pre-commit: Update ruff version, use current repo Use the latest ruff version (v0.6.1) from the current official ruff repo * Use `is` for type comparisons Fix ruff E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks * Remove redefinition of unused `stack` Fix ruff F811 in solara\toestand.py:148:40: F811 Redefinition of unused `stack` from line 147 * Run ruff on Jupyter Notebooks Ruff now also works on Jupyter notebooks by default * Revert "Run pre-commit" This reverts commit f530ef8. * CI: Update code-quality to use Python 3.9 and 3.12 Python 3.9 is the lowest version pre-commit supports. See pre-commit/pre-commit#3042 * Run pre-commit pyupgrade * Fix pre-commit config warning in mypy hook Fix: [WARNING] The 'exclude' field in hook 'mypy' is a regex, not a glob -- matching '/*' probably isn't what you want here In regex, `.` matches any character except a newline, and `*` matches zero or more of the preceding element (in this case, any character). `.*` effectively replaces the `/*` glob pattern. * Pre-commit: add check-toml, update mypy syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my hands are tied -- if you want to complain do it here: python/cpython#106532