Fix getdefines calls for Ninja, compile commands, and CodeLite - #2801
Merged
Conversation
samsinsane
approved these changes
Sep 8, 2026
Jarod42
reviewed
Sep 8, 2026
Jarod42
left a comment
Contributor
There was a problem hiding this comment.
Maybe comment from msc.getdefines(defines, cfg) (the one telling cfg=nil is deprecated) can be removed too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes how
getdefinesis called amongst exporters. Ensures the relevant config is passed.How does this PR change Premake's behavior?
Addresses issues where defines were reliant on a passed config.
Anything else we should know?
Resolves #2800
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!