Uh oh!
There was an error while loading. Please reload this page.
fix: compatibility with prettier 2.0 - #1359
Merged
Merged
Conversation
czoselforce-pushed
the
prettier-2.0
branch
2 times, most recently
from
March 25, 2020 19:21
30633c8 to
a43dd88Compareczosel
commented
Mar 25, 2020
| node, | ||
| lookupIfPrettier2(options, "locEnd") | ||
| ); | ||
| } |
CollaboratorAuthor
There was a problem hiding this comment.
These are the actual code changes
(probably should've done a separate commit for the formatting changes 🙈)
alexander-akait
left a comment
Member
There was a problem hiding this comment.
I am afraid it is breaking change
czosel
commented
Mar 26, 2020
CollaboratorAuthor
You can try checking out this branch, and after run |
alexander-akait
commented
Mar 26, 2020
Member
Great, go ahead |
matzeeable
commented
Mar 28, 2020
@czosel Awesome! When will this be published as new version to https://www.npmjs.com/package/@prettier/plugin-php ? 🙂 |
CollaboratorAuthor
@matzeeable I hope we can make a release in the next few days, all that's missing are some reviews to open pull requests 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier 2.0 brought some breaking changes with it (see here). This implements the new API in a backwards-compatible way. CI currently doesn't proof the fact that it still works with 1.x, and since the breaking changes are few and nicely encapsulated, I'd keep CI as is.
Fixes#1352