Uh oh!
There was an error while loading. Please reload this page.
Support doctrine 4 - #39
Conversation
kimpepper
left a comment
There was a problem hiding this comment.
Reviewed the new GitHub Actions workflow.
- PHP provisioning: We don't usually use
shivammathur/setup-php. Suggested running the job inside the standard Skpr PHP CLI container (skpr/php-cli:<version>-dev-v2-latest), which ships Composer and git. - Action versions:
actions/checkout@v4andactions/upload-artifact@v4are ~3 majors behind; bumped to the latest (v7). - Composer:
--no-suggestwas removed in Composer 2.
Note: -latest image tags float the PHP patch version, which is fine for CI and consistent with other Skpr projects.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kimpepper
left a comment
There was a problem hiding this comment.
Follow-up to the previous review: instead of emitting a JUnit XML artifact, use a PHPUnit problem matcher so test failures surface inline as annotations. This supersedes the earlier upload-artifact@v7 suggestion.
Uh oh!
There was an error while loading. Please reload this page.
…poser.lock - Set PHP minimum to 8.2 - Bump dev dependencies to highest minor+patch (coder 9, phpcs 4, phpstan 2, phpunit 11) - Migrate phpunit.xml.dist to PHPUnit 11 schema - Convert @group annotation to #[Group] attribute - Remove abandoned pear/console_table and unused printTree() debug helper - Remove redundant always-true assert($stmt instanceof Result) calls - Fix Drupal 9.x coding standard whitespace - Untrack and gitignore composer.lock (library)
Uh oh!
There was an error while loading. Please reload this page.
Drupal 12 require symfony 8
Symfony 8 requires doctrine 4+
Additional high-level changes in this PR:
--teamcityproblem matcher and PHPCS to checkstyle +cs2prfor inline annotations.pear/console_tableandphpcompatibility/php-compatibility; addedcs2pr.composer.lockand added it to.gitignore(library convention).phpunit.xml.distto the PHPUnit 11 schema and@groupannotation to a#[Group]attribute.