Skip to content

Marketing: add link components - #1807

Merged
tobiasahlin merged 39 commits into
mainfrom
enstyled/marketing-link-component
Dec 6, 2021
Merged

Marketing: add link components#1807
tobiasahlin merged 39 commits into
mainfrom
enstyled/marketing-link-component

Conversation

@enstyled

@enstyledenstyled commented Dec 2, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Upstreaming the marketing link component from github/github, while doing slight refactoring.
  • Extracting a reusable animated arrow utility
  • Reuse the animated arrow in marketing buttons

Fixeshttps://github.com/github/site-design/issues/1417

@changeset-bot

changeset-botBot commented Dec 2, 2021•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3923ea6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/cssMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tobiasahlin
tobiasahlin reviewed Dec 2, 2021
View reviewed changes

@tobiasahlintobiasahlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Some minor notes 👀 I think if we fix that + add some documentation and outline the different variants in the documentation, I think this is ✨👌

Comment threadsrc/marketing/links/link.scss Outdated
Comment threadsrc/marketing/index.scss
tobiasahlin
tobiasahlin reviewed Dec 3, 2021
View reviewed changes
Comment threadsrc/marketing/utilities/animations.scss
@enstyled@tobiasahlin
Expand the arrow-target-mktg selector to cover btn-mktg and link-mktg
f5548ae
Co-authored-by: Tobias Ahlin <hello@tobiasahlin.com>
langermank
langermank reviewed Dec 3, 2021
View reviewed changes

@langermanklangermank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, not blocking if this is more of a move-code-to-primer PR :)

I'm also curious, is the padding on marketing buttons intentionally uneven?
image
image

Comment threadsrc/marketing/links/link.scss
Comment threadsrc/marketing/utilities/animations.scss
@enstyled

enstyled commented Dec 3, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'm also curious, is the padding on marketing buttons intentionally uneven?

Noticed the same and tried to investigate what is the reason - it has something to do with the custom web font we use in marketing. We have agreed to work on it in a separate PR.

@tobiasahlin
tobiasahlin enabled auto-merge (squash) December 6, 2021 08:48
@tobiasahlin
tobiasahlin merged commit 13a4654 into mainDec 6, 2021
@tobiasahlin
tobiasahlin deleted the enstyled/marketing-link-component branch December 6, 2021 08:50
This was referenced Dec 6, 2021
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simuraisimuraisimurai approved these changes
@tobiasahlintobiasahlinAwaiting requested review from tobiasahlin
+1 more reviewer
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@enstyled@tobiasahlin@simurai@langermank@actions-user