Skip to content

drop !important from details styling - #2611

Merged
langermank merged 2 commits into
mainfrom
drop-important-from-details-styling
May 7, 2024
Merged

drop !important from details styling#2611
langermank merged 2 commits into
mainfrom
drop-important-from-details-styling

Conversation

@keithamus

Copy link
Copy Markdown
Contributor

What are you trying to accomplish?

Fixes#2592

What approach did you choose and why?

Removed !important

What should reviewers focus on?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@keithamus
keithamus requested a review from a team as a code ownerApril 18, 2024 08:11
@keithamus
keithamus requested a review from jonrohanApril 18, 2024 08:11
@changeset-bot

changeset-botBot commented Apr 18, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df417bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/cssPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank
langermank merged commit e867934 into mainMay 7, 2024
@langermank
langermank deleted the drop-important-from-details-styling branch May 7, 2024 14:19
@primerprimerBot mentioned this pull request May 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doing find-in-page for text in GitHub PR/issue pages doesn’t cause expected auto-expansion of closed “details” elements that have matches

2 participants

@keithamus@langermank