Uh oh!
There was an error while loading. Please reload this page.
Style buttons as selected on <details open> - #346
Conversation
shawnbot
commented
Sep 13, 2017
This gets a big 👍 from me. Slightly off-topic of this PR, but I'm not quite sure where else to put it: Should we consider adding either That commit also adopts an approach that @keithamus suggested, minting some new classes: |
muan
commented
Sep 15, 2017
@shawnbot thanks! I commented on that PR about the reset styles. |
shawnbot
left a comment
There was a problem hiding this comment.
This is great. It means that folks can prototype with <details> and no JS! Let's get this included in 9.5.0 ASAP.
We are trying to convert more and more core function dropdowns on the site to using
<details>. I'm currently working on https://github.com/github/github/pull/78190 and we need the selected state on<summary class="btn">without the.selectedclass being added since the<details>pattern uses no JavaScript.I'm curious what you all think about this, and if there is a better solution. ⭐ Happy to explore.
/cc @primer/ds-core