Missing generated prop documentation for TextInput

[colebemis]

Problem

The Props component that we use to generate prop documentation doesn't work with the TextInput component:

Tasks

• Investigate and fix missing generated prop documentation for TextInput

Notes

The Props component was added in this PR and is implemented with react-docgen-typescript. I'm guessing there are other components that don't work with the Props component as well.

[siddharthkp]

🕵️ This is what I have till now:

The props don't show up because they aren't generated by react-docgen-typescript. It skips the TextInput component without a warning.

They did have trouble with React.forwardRef but those were fixed in the version we are using. So now, I'm trying to figure out what part of the TextInput does docgen not like based on the test fixtures in their repo.

Trying to make the smallest reproducible bug, it seems like docgen isn't able to parse this specific line. Still looking for the fix.

[colebemis]

Excellent detective work, @siddharthkp 🕵️ ✨

Seems like the solution to this issue is either simplify the way we right types or change how we generate prop documentation (maybe we could use ts-morph). Either way, this seems like more work than we initially estimated. Let's move this back into the backlog until we can prioritize this.

I also think this calls for a more general discussion about how we want to handle prop documentation (i.e. can it be generated or is manually maintaining it okay?). Can you create a discussion about that in github/primer or primer/react when you have a chance?

[siddharthkp]

Started a discussion to log exploration work: #1492

[pksjce]

This doesn't seem to be relevant anymore as TextInput and doc issues have been fixed. Please re-open if required.