Skip to content

Dialog2 should use h1 and h2 for title and description #1753

Description

@owenniblock

Describe the bug

For accessibility (and semantic correctness) our dialog should present the title and description parameters in <h1> and <h2> tags.

Currently the example in the docs shows that this uses <div> see this link to the docs for Dialog2

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://primer.style/react/Dialog2#example
  2. Click on Open
  3. Inspect the title and description text
  4. See that they're <div> elements

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions