You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are console.{error,warn,log} statements being emitted when running npm test. This can be confusing to contributors who may not understand if the issues are pre-existing or caused by changes that they made when making a contribution.
This issue has two goals:
Add a system by which we can fail tests that call console.{error, warn, log} (Note: console.log() should only fail in CI)
Update tests which currently fail when adding this check
Currently there are
console.{error,warn,log}statements being emitted when runningnpm test. This can be confusing to contributors who may not understand if the issues are pre-existing or caused by changes that they made when making a contribution.This issue has two goals:
console.{error, warn, log}(Note:console.log()should only fail in CI)src/drafts/MarkdownEditor/MarkdownEditor.test.tsxsrc/__tests__/useSafeTimeout.test.tsxsrc/__tests__/TabNav.test.tsxsrc/drafts/MarkdownViewer/MarkdownViewer.test.tsxsrc/__tests__/Textarea.test.tsxsrc/drafts/hooks/useIgnoreKeyboardActionsWhileComposing.test.tsxsrc/__tests__/RadioGroup.test.tsxsrc/__tests__/Select.test.tsxsrc/__tests__/Radio.test.tsxsrc/__tests__/CheckboxGroup.test.tsxsrc/__tests__/CheckboxOrRadioGroup.test.tsxsrc/NavList/NavList.test.tsxsrc/__tests__/deprecated/ChoiceInputField.test.tsxsrc/__tests__/Autocomplete.test.tsxsrc/SegmentedControl/SegmentedControl.test.tsxsrc/__tests__/FormControl.test.tsxsrc/__tests__/ThemeProvider.test.tsx